On Wed, Aug 23, 2023 12:05 PM Li, Zhijian wrote: > > Daisuke > > > Thanks for your reviewing, beside this place, i just noticed that > there are so many places missing newline in rxe driver > > except rxe_err() rxe_info() rxe_dbg() already auto added newline in the macros, These built-in newline characters should be removed. In the kernel, "*fmt" is expected to include a newline character. We should remove '\n' from the definitions of these functions, and add '\n' to each caller. > other macros should append newline by hand when being used. Yes, they also need to be fixed. Daisuke > > A roughly count: > # git grep -n -e rxe_info -e rxe_err -e rxe_dbg | grep -v '#define' | grep -v '\\n' | wc -l > 146 > > > i will do a big cleanup for all of them later. > > Thanks > Zhijian > > > > On 23/08/2023 10:43, Matsuda, Daisuke/松田 大輔 wrote: > > On Wed, Aug 23, 2023 11:13 AM Li Zhijian wrote: > >> > >> A newline help flushing message out. > >> > >> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx> > >> --- > >> drivers/infiniband/sw/rxe/rxe.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c > >> index 54c723a6edda..cb2c0d54aae1 100644 > >> --- a/drivers/infiniband/sw/rxe/rxe.c > >> +++ b/drivers/infiniband/sw/rxe/rxe.c > >> @@ -161,7 +161,7 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu) > >> port->attr.active_mtu = mtu; > >> port->mtu_cap = ib_mtu_enum_to_int(mtu); > >> > >> - rxe_info_dev(rxe, "Set mtu to %d", port->mtu_cap); > >> + rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap); > >> } > >> > >> /* called by ifc layer to create new rxe device. > >> -- > >> 2.29.2 > > > > Reviewed-by: Daisuke Matsuda <matsuda-daisuke@xxxxxxxxxxx> > >
