On 8/10/23 17:44, Dennis Dalessandro wrote:
Commit: 699826f4e30a ("IB/isert: Fix incorrect release of isert connection") is
causing problems on OPA when we try to unload the driver after doing iSCI
testing. Reverting this commit causes the problem to go away. Any ideas? Was
testing done on this patch with removing/hotplugging drivers?
You are correct, the patch is wrong because it doesn't fully release the
connection in ib device surprise removals.
Perhaps this should address this issue?
--
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c
b/drivers/infiniband/ulp/isert/ib_isert.c
index 92e1e7587af8..274ac9361fe7 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -2570,6 +2570,9 @@ static void isert_wait_conn(struct iscsit_conn *conn)
isert_put_unsol_pending_cmds(conn);
isert_wait4cmds(conn);
isert_wait4logout(isert_conn);
+
+ isert_put_conn(isert_conn);
+ conn->context = NULL;
}
static void isert_free_conn(struct iscsit_conn *conn)
--
