On 8/10/23 03:04, Jason Gunthorpe wrote:
On Thu, Jul 27, 2023 at 10:03:44PM +0800, Guoqing Jiang wrote:Hi, Several issues appeared if we rmmod siw module after failed to insert the module (with manual change like below). --- a/drivers/infiniband/sw/siw/siw_main.c +++ b/drivers/infiniband/sw/siw/siw_main.c @@ -577,6 +577,7 @@ static __init int siw_init_module(void) if (rv) goto out_error; + goto out_error; rdma_link_register(&siw_link_ops); Basically, these issues are double free, use before initalization or null pointer dereference. For more details, pls review the individual patch. Thanks, Guoqing Guoqing Jiang (5): RDMA/siw: Set siw_cm_wq to NULL after it is destroyed RDMA/siw: Ensure siw_destroy_cpulist can be called more than once RDMA/siw: Initialize siw_link_ops.list RDMA/siw: Set siw_crypto_shash to NULL after it is freed RDMA/siw: Don't call wake_up unconditionally in siw_stop_tx_threadWhat is the status of this series? Bernards fix for some of this was already merged and this doesn't apply, so regardless it needs resending.
After Bernard's fix was already merged, and other patches are not needed since it is impossible to trigger them in real life. So pls just ignore this series. Thanks, Guoqing
