On 8/7/23 15:58, Simon Horman wrote: > On Fri, Aug 04, 2023 at 05:05:20PM +0200, Petr Pavlu wrote: > > ... > >> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_main.c b/drivers/net/ethernet/mellanox/mlx4/en_main.c > > ... > >> @@ -326,6 +333,11 @@ static void *mlx4_en_add(struct mlx4_dev *dev) >> mutex_init(&mdev->state_lock); >> mdev->device_up = true; >> >> + /* register mlx4 core notifier */ >> + mdev->mlx_nb.notifier_call = mlx4_en_event; >> + err = mlx4_register_event_notifier(dev, &mdev->mlx_nb); > > Hi Petr. > > This fails to build because err isn't declared in this context. Ah, the err variable in mlx4_en_add() is only defined by a subsequent patch in the series. I'll fix it in v2. Thanks, Petr
