On 7/31/23 13:17, Jason Gunthorpe wrote: > On Fri, Jul 21, 2023 at 03:50:22PM -0500, Bob Pearson wrote: >> Network interruptions may cause long delays in the processing of >> send packets during which time the rxe driver may be unloaded. >> This will cause seg faults when the packet is ultimately freed as >> it calls the destructor function in the rxe driver. This has been >> observed in cable pull fail over fail back testing. > > No, module reference counts are only for code that is touching > function pointers. this is exactly the case here. it is the skb destructor function that is carried by the skb. > > If your driver is becoming removed and that messes it up then you need > to prevent the driver from unloading by adding something to the remove > function (dellink, I guess in this case) > > Jason