On Wed, Jul 19, 2023 at 12:43 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > On Tue, Jul 18, 2023 at 11:00:32AM -0700, Souradeep Chakrabarti wrote: > > At present hwc timeout value is a fixed value. This patch sets the hwc > > timeout from the hardware. It now uses a new hardware capability > > GDMA_DRV_CAP_FLAG_1_HWC_TIMEOUT_RECONFIG to query and set the value > > in hwc_timeout. > > > > Signed-off-by: Souradeep Chakrabarti <schakrabarti@xxxxxxxxxxxxxxxxxxx> > > --- > > V3 -> V4: > > * Changing branch to net-next. > > * Changed the commit message to 75 chars per line. > > --- > > .../net/ethernet/microsoft/mana/gdma_main.c | 30 ++++++++++++++++++- > > .../net/ethernet/microsoft/mana/hw_channel.c | 25 +++++++++++++++- > > include/net/mana/gdma.h | 20 ++++++++++++- > > include/net/mana/hw_channel.h | 5 ++++ > > 4 files changed, 77 insertions(+), 3 deletions(-) > > <...> > > > gc->hwc.driver_data = NULL; > > gc->hwc.gdma_context = NULL; > > @@ -818,6 +839,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len, > > dest_vrq = hwc->pf_dest_vrq_id; > > dest_vrcq = hwc->pf_dest_vrcq_id; > > } > > + dev_err(hwc->dev, "HWC: timeout %u ms\n", hwc->hwc_timeout); > > Why do you print this message every time and with error level? > Probably you should delete it. > In V5 I have changed it to dev_dbg from dev_err. > Thanks
