On Fri, Jun 30, 2023 at 05:30:59PM -0700, Randy Dunlap wrote:
> When INFINIBAND_USER_ACCESS is not set, the bnxt_re driver has
> build errors:
>
> ERROR: modpost: "uverbs_idr_class" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "ib_uverbs_get_ucontext_file" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "uverbs_destroy_def_handler" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
>
> Handle this case by making the driver depend on INFINIBAND_USER_ACCESS.
>
> Fixes: 592e8b3226a2 ("RDMA/bnxt_re: Add bnxt_re driver build support")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Cc: Leon Romanovsky <leonro@xxxxxxxxxx>
> Cc: linux-rdma@xxxxxxxxxxxxxxx
> Cc: Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>
> Cc: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>
> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@xxxxxxxxxxxx>
> Cc: Doug Ledford <dledford@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
I liked this variant [1] more as bnxt_re driver can theoretically work
without INFINIBAND_USER_ACCESS too.
[1] https://lore.kernel.org/all/20230703113025.356682-1-arnd@xxxxxxxxxx
Thanks
