On 13/06/2023 23:50, Jakub Kicinski wrote:
All callers of tls_is_sk_tx_device_offloaded() currently do an equivalent of: if (skb->sk && tls_is_skb_tx_device_offloaded(skb->sk)) Have the helper accept skb and do the skb->sk check locally. Two drivers have local static inlines with similar wrappers already. While at it change the ifdef condition to TLS_DEVICE. Only TLS_DEVICE selects SOCK_VALIDATE_XMIT, so the two are equivalent. This makes removing the duplicated IS_ENABLED() check in funeth more obviously correct. Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> --- CC: j.vosburgh@xxxxxxxxx CC: andy@xxxxxxxxxxxxx CC: rajur@xxxxxxxxxxx CC: ayush.sawal@xxxxxxxxxxx CC: dmichail@xxxxxxxxxxxx CC: borisp@xxxxxxxxxx CC: saeedm@xxxxxxxxxx CC: leon@xxxxxxxxxx CC: simon.horman@xxxxxxxxxxxx CC: john.fastabend@xxxxxxxxx CC: anirudh.venkataramanan@xxxxxxxxx CC: maxtram95@xxxxxxxxx CC: tariqt@xxxxxxxxxx
Acked-by: Tariq Toukan <tariqt@xxxxxxxxxx> Thanks.