[PATCH v2 for-next] RDMA/rxe: Fixes mr access supported list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A recent patch incorrectly did not include IB_ACCESS_RELAXED_ORDERING
in the list of supported access flags for the rxe driver. The driver
actually does nothing related to relaxed ordering but it causes no
problems to include it as supported but with no effect. This change
caused ib_send_bw and friends to not run correctly.

The correct approach is for the driver to allow any of the optional
access flags and otherwise ignore them. This patch adds
IB_ACCESS_OPTIONAL to the list of rxe supported flags.

Link: https://lore.kernel.org/linux-rdma/ZIifmHzwnvn3YVbI@xxxxxxxxxx/raw
Fixes: 02ed253770fb ("RDMA/rxe: Introduce rxe access supported flags")
Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
---
v2: Changed the target to for-next since the error is not currently in
    for-rc. Replaced IB_ACCESS_RELAXED_ORDERING by IB_ACCESS_OPTIONAL
    per a suggestion by Jason Gunthorpe.
---
 drivers/infiniband/sw/rxe/rxe_verbs.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index cb18b83b73c1..ccb9d19ffe8a 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -262,7 +262,8 @@ enum {
 				| IB_ACCESS_MW_BIND
 				| IB_ACCESS_ON_DEMAND
 				| IB_ACCESS_FLUSH_GLOBAL
-				| IB_ACCESS_FLUSH_PERSISTENT,
+				| IB_ACCESS_FLUSH_PERSISTENT
+				| IB_ACCESS_OPTIONAL,
 	RXE_ACCESS_SUPPORTED_QP	= RXE_ACCESS_SUPPORTED_MR,
 	RXE_ACCESS_SUPPORTED_MW	= RXE_ACCESS_SUPPORTED_MR
 				| IB_ZERO_BASED,

base-commit: 830f93f47068b1632cc127871fbf27e918efdf46
-- 
2.39.2




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux