On Tue, Jun 13, 2023 at 1:46 PM Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Fix compilation warning:
>
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:325:18:
> error: variable 'opcode' is uninitialized when used here [-Werror,-Wuninitialized]
> crsqe->opcode = opcode;
> ^~~~~~
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:291:11:
> note: initialize the variable 'opcode' to silence this warning
> u8 opcode;
> ^
> = '\0'
>
> Fixes: bcfee4ce3e01 ("RDMA/bnxt_re: remove redundant cmdq_bitmap")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx>
Thanks
> ---
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
> index bb5aebafe162..92b3a4fbd0b2 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_rcfw.c
> @@ -274,7 +274,7 @@ static void __send_message_no_waiter(struct bnxt_qplib_rcfw *rcfw,
> }
>
> static int __send_message(struct bnxt_qplib_rcfw *rcfw,
> - struct bnxt_qplib_cmdqmsg *msg)
> + struct bnxt_qplib_cmdqmsg *msg, u8 opcode)
> {
> u32 bsize, free_slots, required_slots;
> struct bnxt_qplib_cmdq_ctx *cmdq;
> @@ -285,7 +285,6 @@ static int __send_message(struct bnxt_qplib_rcfw *rcfw,
> struct pci_dev *pdev;
> unsigned long flags;
> u16 cookie;
> - u8 opcode;
> u8 *preq;
>
> cmdq = &rcfw->cmdq;
> @@ -490,7 +489,7 @@ static int __bnxt_qplib_rcfw_send_message(struct bnxt_qplib_rcfw *rcfw,
> if (rc)
> return rc == -ENXIO ? bnxt_qplib_map_rc(opcode) : rc;
>
> - rc = __send_message(rcfw, msg);
> + rc = __send_message(rcfw, msg, opcode);
> if (rc)
> return rc;
>
> --
> 2.40.1
>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
