Jason, thanks. - Bob
-----Original Message-----
From: Jason Gunthorpe <jgg@xxxxxxxxxx>
Sent: Monday, June 12, 2023 1:28 PM
To: Bob Pearson <rpearsonhpe@xxxxxxxxx>
Cc: zyjzyj2000@xxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx
Subject: Re: [PATCH for-next] RDMA/rxe: Fix rxe_cq_post
On Mon, Jun 12, 2023 at 10:50:33AM -0500, Bob Pearson wrote:
> A recent patch replaced a tasklet execution of cq->comp_handler by a
> direct call. While this made sense it let changes to cq->notify state
> be unprotected and assumed that the cq completion machinery and the
> ulp done callbacks were reentrant. The result is that in some cases
> completion events can be lost. This patch moves the
> cq->comp_handler call inside of the spinlock in rxe_cq_post which
> solves both issues. This is compatible with the matching code in the
> request notify verb.
>
> Fixes: 78b26a335310 ("RDMA/rxe: Remove tasklet call from rxe_cq.c")
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_cq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-rc, thanks
Jason
