On Fri, Jun 09, 2023 at 04:01:37AM -0700, Selvin Xavier wrote: > This patch series from Kashyap includes code refactoring and some > optimizations in the FW control path of the driver. It also address > some of the issues seen as we scale up the HW resources. > It also includes few bug fixes in the control path. > > Please review and apply. > > Thanks, > Selvin Xavier > > v1 -> v2: > - Fix the warning reported by kbuild test robot in patch 10 about > variables set and not used. Rebased the other patches based on > the modified patch. > - Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Kashyap Desai (17): > RDMA/bnxt_re: wraparound mbox producer index > RDMA/bnxt_re: Avoid calling wake_up threads from spin_lock context > RDMA/bnxt_re: remove virt_func check while creating RoCE FW channel > RDMA/bnxt_re: set fixed command queue depth > RDMA/bnxt_re: Enhance the existing functions that wait for FW > responses > RDMA/bnxt_re: Avoid the command wait if firmware is inactive > RDMA/bnxt_re: use shadow qd while posting non blocking rcfw command > RDMA/bnxt_re: Simplify the function that sends the FW commands > RDMA/bnxt_re: add helper function __poll_for_resp > RDMA/bnxt_re: handle command completions after driver detect a > timedout > RDMA/bnxt_re: Add firmware stall check detection > RDMA/bnxt_re: post destroy_ah for delayed completion of AH creation > RDMA/bnxt_re: consider timeout of destroy ah as success. > RDMA/bnxt_re: cancel all control path command waiters upon error. > RDMA/bnxt_re: use firmware provided max request timeout > RDMA/bnxt_re: remove redundant cmdq_bitmap > RDMA/bnxt_re: optimize the parameters passed to helper functions I applied whole series as is. It looks good enough, but please address my concern about atomit_t. Thanks > > drivers/infiniband/hw/bnxt_re/bnxt_re.h | 2 + > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 16 +- > drivers/infiniband/hw/bnxt_re/main.c | 11 +- > drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 627 ++++++++++++++++++++++------- > drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 51 ++- > drivers/infiniband/hw/bnxt_re/qplib_res.h | 1 + > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 8 +- > drivers/infiniband/hw/bnxt_re/qplib_sp.h | 4 +- > 8 files changed, 557 insertions(+), 163 deletions(-) > > -- > 2.5.5 >