> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Wednesday, June 7, 2023 4:38 PM > To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Cc: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>; Paul Rosswurm > <paulros@xxxxxxxxxxxxx>; olaf@xxxxxxxxx; vkuznets@xxxxxxxxxx; > davem@xxxxxxxxxxxxx; wei.liu@xxxxxxxxxx; edumazet@xxxxxxxxxx; > pabeni@xxxxxxxxxx; leon@xxxxxxxxxx; Long Li <longli@xxxxxxxxxxxxx>; > ssengar@xxxxxxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > daniel@xxxxxxxxxxxxx; john.fastabend@xxxxxxxxx; bpf@xxxxxxxxxxxxxxx; > ast@xxxxxxxxxx; Ajay Sharma <sharmaajay@xxxxxxxxxxxxx>; > hawk@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; shradhagupta@xxxxxxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next,V2] net: mana: Add support for vlan tagging > > On Wed, 7 Jun 2023 13:34:02 -0700 Haiyang Zhang wrote: > > To support vlan, use MANA_LONG_PKT_FMT if vlan tag is present in TX > > skb. Then extract the vlan tag from the skb struct, and save it to > > tx_oob for the NIC to transmit. For vlan tags on the payload, they > > are accepted by the NIC too. > > > > For RX, extract the vlan tag from CQE and put it into skb. > > > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > --- > > V2: > > Removed the code that extracts inband tag, because our NIC accepts > > inband tags too. > > Please don't rush multiple versions, if your previous version is buggy > you have to reply to it saying so and then wait before posting v2. Will do. Thanks.
