From: Saeed Mahameed <saeed@xxxxxxxxxx> Date: Tue, 6 Jun 2023 00:12:13 -0700 > From: Dragos Tatulea <dtatulea@xxxxxxxxxx> > > The page_pool error message is a bit cryptic when the > requested size is too large. Add a message on the driver > side to display how many pages were actually requested. Why not rather expand Page Pool's "gave up with error" into detailed error messages? I thought we usually go the other way around in the upstream and make stuff as generic as possible :D With this patch, you'll have 2 error messages at the same time: Page Pool's one and then yours. > > Signed-off-by: Dragos Tatulea <dtatulea@xxxxxxxxxx> > Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx> > Signed-off-by: Saeed Mahameed <saeedm@xxxxxxxxxx> [...] Thanks, Olek