> -----Original Message-----
> From: Jason Gunthorpe <jgg@xxxxxxxx>
> Sent: Monday, June 5, 2023 9:35 PM
> To: Simon Horman <simon.horman@xxxxxxxxxxxx>
> Cc: Wei Hu <weh@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> hyperv@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Long Li
> <longli@xxxxxxxxxxxxx>; Ajay Sharma <sharmaajay@xxxxxxxxxxxxx>;
> leon@xxxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; wei.liu@xxxxxxxxxx; Dexuan Cui
> <decui@xxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; vkuznets@xxxxxxxxxx;
> ssengar@xxxxxxxxxxxxxxxxxxx; shradhagupta@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] RDMA/mana_ib: Add EQ interrupt support to mana
> ib driver.
>
> On Mon, Jun 05, 2023 at 03:15:05PM +0200, Simon Horman wrote:
> > On Mon, Jun 05, 2023 at 11:43:13AM +0000, Wei Hu wrote:
> > > Add EQ interrupt support for mana ib driver. Allocate EQs per
> > > ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ
> > > interrupt handler when completion interrupt happens. EQs are
> > > destroyed when ucontext is deallocated.
> > >
> > > The change calls some public APIs in mana ethernet driver to
> > > allocate EQs and other resources. Ehe EQ process routine is also
> > > shared by mana ethernet and mana ib drivers.
> > >
> > > Co-developed-by: Ajay Sharma <sharmaajay@xxxxxxxxxxxxx>
> > > Signed-off-by: Ajay Sharma <sharmaajay@xxxxxxxxxxxxx>
> > > Signed-off-by: Wei Hu <weh@xxxxxxxxxxxxx>
> >
> > ...
> >
> > > @@ -368,6 +420,24 @@ static int mana_ib_create_qp_raw(struct ib_qp
> *ibqp, struct ib_pd *ibpd,
> > > qp->sq_id = wq_spec.queue_index;
> > > send_cq->id = cq_spec.queue_index;
> > >
> > > + if (gd->gdma_context->cq_table[send_cq->id] == NULL) {
> > > +
> > > + gdma_cq = kzalloc(sizeof(*gdma_cq), GFP_KERNEL);
> > > + if (!gdma_cq) {
> > > + pr_err("failed to allocate gdma_cq\n");
> >
> > Hi wei Hu,
> >
> > I think 'err = -ENOMEM' is needed here.
>
> And no prints like that in drivers.
>
Thanks for your review, Simon and Jason. You are right.
I have overlooked these. I will fix it and send a v2 shortly.
Wei
