On 5/16/23 19:11, Jason Gunthorpe wrote: > On Mon, May 15, 2023 at 03:10:57PM -0500, Bob Pearson wrote: >> A recent patch can cause a double spin_unlock_bh() in rxe_qp_to_attr() >> at line 715 in rxe_qp.c. This patch corrects that behavior. >> >> A newer patch from Guoqing Jiang recommends replacing all spin_lock >> calls for qp->state_lock to spin_(un)lock_irqsave(restore)() since >> apparently the blktests test suite can call the kernel verbs APIs >> while in hard interrupt state. This patch needs to be applied first >> and Guoqing's patch modified to accommodate this small change. >> >> Fixes: f605f26ea196 ("RDMA/rxe: Protect QP state with qp->state_lock") >> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> >> Closes: https://lore.kernel.org/linux-rdma/27773078-40ce-414f-8b97-781954da9f25@kili.mountain/ >> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx> >> --- >> drivers/infiniband/sw/rxe/rxe_qp.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Applied to for-rc, thanks > > Jason Thanks