在 2023/4/21 23:27, Jason Gunthorpe 写道:
On Tue, Apr 18, 2023 at 08:26:11PM +0800, Zhu Yanjun wrote:
From: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
Add the function names to the pr_ logs. As such, if some bugs occur,
with function names, it is easy to locate the bugs.
Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
---
drivers/infiniband/sw/rxe/rxe.h | 2 +-
drivers/infiniband/sw/rxe/rxe_queue.h | 16 ++++------------
2 files changed, 5 insertions(+), 13 deletions(-)
After you delete the warn_on's there is very little left:
rivers/infiniband/sw/rxe/rxe.c: pr_err("rxe creation allowed on top of a real device only\n");
drivers/infiniband/sw/rxe/rxe.c: pr_info("loaded\n");
drivers/infiniband/sw/rxe/rxe.c: pr_info("unloaded\n");
drivers/infiniband/sw/rxe/rxe_net.c: pr_err("Failed to create IPv4 UDP tunnel\n");
drivers/infiniband/sw/rxe/rxe_net.c: pr_warn("IPv6 is not supported, can not create a UDPv6 socket\n");
drivers/infiniband/sw/rxe/rxe_net.c: pr_err("Failed to create IPv6 UDP tunnel\n");
drivers/infiniband/sw/rxe/rxe_net.c: pr_err("Failed to register netdev notifier\n");
It is not exactly mysterious where these come from?
If I got you correctly, you mean that we can easily locate the above
pr_xxx logs. As such, it is not necessary to add function names.
From this perspective, I agree with you.
Why I make this commit is that we can directly use this pr_info("xxxxx")
when some bug occurs. But in the logs, the function names appear.
With this commit, we can decrease some work loads with some bug occurs.
Now I am debugging a problem. With a similar commit with this, I
directly use pr_warn("xxx"). But in the logs, function names, line
number, file names, caller and so on will appear.
This greatly decrease my workloads.
I think this is a smart method. So I introduce this smart method to
softroce. When some bugs occur in softroce, this method can help us.
Zhu Yanjun
Why do we need the function name?
Jason
