On Mon, Apr 10, 2023 at 04:11:52AM -0700, Selvin Xavier wrote: > Query Function capabilities to enable advanced features. > > Signed-off-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> > --- > drivers/infiniband/hw/bnxt_re/main.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c > index a866951..1b69198 100644 > --- a/drivers/infiniband/hw/bnxt_re/main.c > +++ b/drivers/infiniband/hw/bnxt_re/main.c > @@ -83,6 +83,7 @@ static int bnxt_re_netdev_event(struct notifier_block *notifier, > unsigned long event, void *ptr); > static struct bnxt_re_dev *bnxt_re_from_netdev(struct net_device *netdev); > static void bnxt_re_dev_uninit(struct bnxt_re_dev *rdev); > +static int bnxt_re_hwrm_qcaps(struct bnxt_re_dev *rdev); > > static void bnxt_re_set_drv_mode(struct bnxt_re_dev *rdev, u8 mode) > { > @@ -91,6 +92,9 @@ static void bnxt_re_set_drv_mode(struct bnxt_re_dev *rdev, u8 mode) > cctx = rdev->chip_ctx; > cctx->modes.wqe_mode = bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx) ? > mode : BNXT_QPLIB_WQE_MODE_STATIC; > + if (bnxt_re_hwrm_qcaps(rdev)) > + dev_err(rdev_to_dev(rdev), > + "Failed to query hwrm qcaps\n"); You already print error in bnxt_re_hwrm_qcaps() > } <...> > +/* Query function capabilities using common hwrm */ > +int bnxt_re_hwrm_qcaps(struct bnxt_re_dev *rdev) <...> > + if (rc) { > + dev_err(rdev_to_dev(rdev), > + "Failed to query capabilities, rc = %#x", rc); > + return rc; > + } > + return 0; > +} > + > static int bnxt_re_net_ring_free(struct bnxt_re_dev *rdev, > u16 fw_ring_id, int type) > { > -- > 2.5.5 >