On Fri, Mar 31, 2023 at 11:38:00PM -0700, Saravanan Vajravel wrote: > When unregistering MAD agent, srpt module has a non-null check > for 'mad_agent' pointer before invoking ib_unregister_mad_agent(). > This check can pass if 'mad_agent' variable holds an error value. > The 'mad_agent' can have an error value for a short window when > srpt_add_one() and srpt_remove_one() is executed simultaneously. Don't fix it like this, don't store err values in global pointers. Jason