> -----Original Message-----
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Sent: Sunday, 2 April 2023 07:10
> To: Bernard Metzler <BMT@xxxxxxxxxxxxxx>; Jason Gunthorpe <jgg@xxxxxxxx>;
> Leon Romanovsky <leon@xxxxxxxxxx>
> Cc: OFED mailing list <linux-rdma@xxxxxxxxxxxxxxx>;
> syzbot+5e70d01ee8985ae62a3b@xxxxxxxxxxxxxxxxxxxxxxxxx; syzkaller-bugs
> <syzkaller-bugs@xxxxxxxxxxxxxxxx>
> Subject: [EXTERNAL] [PATCH] RDMA/siw: remove namespace check from
> siw_netdev_event()
>
> syzbot is reporting that siw_netdev_event(NETDEV_UNREGISTER) cannot destroy
> siw_device created after unshare(CLONE_NEWNET) due to net namespace check.
> It seems that this check was by error there and should be removed.
>
> Reported-by: syzbot <syzbot+5e70d01ee8985ae62a3b@xxxxxxxxxxxxxxxxxxxxxxxxx>
> Link: INVALID URI REMOVED
> 3A__syzkaller.appspot.com_bug-3Fextid-
> 3D5e70d01ee8985ae62a3b&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=2TaYXQ0T-
> r8ZO1PP1alNwU_QJcRRLfmYTAgd3QCvqSc&m=Vq8ic5smZk4c30D3-f7meZj_nIZP-
> Js0SjZLqzyh5UT4cXVOTulkVhB0SFMVjdV3&s=voUxLOC4jZQi8diPtrEU3qUWKJDq_w2d-
> dWLDKd0nUo&e=
> Suggested-by: Jason Gunthorpe <jgg@xxxxxxxx>
> Suggested-by: Leon Romanovsky <leon@xxxxxxxxxx>
> Fixes: bdcf26bf9b3a ("rdma/siw: network and RDMA core interface")
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/sw/siw/siw_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw_main.c
> b/drivers/infiniband/sw/siw/siw_main.c
> index dacc174604bf..65b5cda5457b 100644
> --- a/drivers/infiniband/sw/siw/siw_main.c
> +++ b/drivers/infiniband/sw/siw/siw_main.c
> @@ -437,9 +437,6 @@ static int siw_netdev_event(struct notifier_block *nb,
> unsigned long event,
>
> dev_dbg(&netdev->dev, "siw: event %lu\n", event);
>
> - if (dev_net(netdev) != &init_net)
> - return NOTIFY_OK;
> -
> base_dev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_SIW);
> if (!base_dev)
> return NOTIFY_OK;
> --
> 2.18.4
Thanks Tetsuo. Yes, that namespace check is useless.
Reviewed-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
