Hi Selvin, I love your patch! Perhaps something to improve: [auto build test WARNING on rdma/for-next] [also build test WARNING on linus/master v6.3-rc3 next-20230323] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Selvin-Xavier/RDMA-bnxt_re-Update-HW-interface-headers/20230323-171441 base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next patch link: https://lore.kernel.org/r/1679562739-24472-8-git-send-email-selvin.xavier%40broadcom.com patch subject: [PATCH for-next 7/7] RDMA/bnxt_re: Enable congestion control by default config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20230323/202303231827.oPu3RsK1-lkp@xxxxxxxxx/config) compiler: ia64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/a8a24a74b6a3209329cc8c157309b156d507cb7d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Selvin-Xavier/RDMA-bnxt_re-Update-HW-interface-headers/20230323-171441 git checkout a8a24a74b6a3209329cc8c157309b156d507cb7d # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/infiniband/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303231827.oPu3RsK1-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/infiniband/hw/bnxt_re/qplib_sp.c:854:6: warning: no previous prototype for 'bnxt_qplib_fill_cc_gen1' [-Wmissing-prototypes] 854 | void bnxt_qplib_fill_cc_gen1(struct cmdq_modify_roce_cc_gen1_tlv *ext_req, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/bnxt_qplib_fill_cc_gen1 +854 drivers/infiniband/hw/bnxt_re/qplib_sp.c 853 > 854 void bnxt_qplib_fill_cc_gen1(struct cmdq_modify_roce_cc_gen1_tlv *ext_req, 855 struct bnxt_qplib_cc_param_ext *cc_ext) 856 { 857 ext_req->modify_mask = cpu_to_le64(cc_ext->ext_mask); 858 cc_ext->ext_mask = 0; 859 ext_req->inactivity_th_hi = cpu_to_le16(cc_ext->inact_th_hi); 860 ext_req->min_time_between_cnps = cpu_to_le16(cc_ext->min_delta_cnp); 861 ext_req->init_cp = cpu_to_le16(cc_ext->init_cp); 862 ext_req->tr_update_mode = cc_ext->tr_update_mode; 863 ext_req->tr_update_cycles = cc_ext->tr_update_cyls; 864 ext_req->fr_num_rtts = cc_ext->fr_rtt; 865 ext_req->ai_rate_increase = cc_ext->ai_rate_incr; 866 ext_req->reduction_relax_rtts_th = cpu_to_le16(cc_ext->rr_rtt_th); 867 ext_req->additional_relax_cr_th = cpu_to_le16(cc_ext->ar_cr_th); 868 ext_req->cr_min_th = cpu_to_le16(cc_ext->cr_min_th); 869 ext_req->bw_avg_weight = cc_ext->bw_avg_weight; 870 ext_req->actual_cr_factor = cc_ext->cr_factor; 871 ext_req->max_cp_cr_th = cpu_to_le16(cc_ext->cr_th_max_cp); 872 ext_req->cp_bias_en = cc_ext->cp_bias_en; 873 ext_req->cp_bias = cc_ext->cp_bias; 874 ext_req->cnp_ecn = cc_ext->cnp_ecn; 875 ext_req->rtt_jitter_en = cc_ext->rtt_jitter_en; 876 ext_req->link_bytes_per_usec = cpu_to_le16(cc_ext->bytes_per_usec); 877 ext_req->reset_cc_cr_th = cpu_to_le16(cc_ext->cc_cr_reset_th); 878 ext_req->cr_width = cc_ext->cr_width; 879 ext_req->quota_period_min = cc_ext->min_quota; 880 ext_req->quota_period_max = cc_ext->max_quota; 881 ext_req->quota_period_abs_max = cc_ext->abs_max_quota; 882 ext_req->tr_lower_bound = cpu_to_le16(cc_ext->tr_lb); 883 ext_req->cr_prob_factor = cc_ext->cr_prob_fac; 884 ext_req->tr_prob_factor = cc_ext->tr_prob_fac; 885 ext_req->fairness_cr_th = cpu_to_le16(cc_ext->fair_cr_th); 886 ext_req->red_div = cc_ext->red_div; 887 ext_req->cnp_ratio_th = cc_ext->cnp_ratio_th; 888 ext_req->exp_ai_rtts = cpu_to_le16(cc_ext->ai_ext_rtt); 889 ext_req->exp_ai_cr_cp_ratio = cc_ext->exp_crcp_ratio; 890 ext_req->use_rate_table = cc_ext->low_rate_en; 891 ext_req->cp_exp_update_th = cpu_to_le16(cc_ext->cpcr_update_th); 892 ext_req->high_exp_ai_rtts_th1 = cpu_to_le16(cc_ext->ai_rtt_th1); 893 ext_req->high_exp_ai_rtts_th2 = cpu_to_le16(cc_ext->ai_rtt_th2); 894 ext_req->actual_cr_cong_free_rtts_th = cpu_to_le16(cc_ext->cf_rtt_th); 895 ext_req->severe_cong_cr_th1 = cpu_to_le16(cc_ext->sc_cr_th1); 896 ext_req->severe_cong_cr_th2 = cpu_to_le16(cc_ext->sc_cr_th2); 897 ext_req->link64B_per_rtt = cpu_to_le32(cc_ext->l64B_per_rtt); 898 ext_req->cc_ack_bytes = cc_ext->cc_ack_bytes; 899 } 900 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
