Bernard Metzler <BMT@xxxxxxxxxxxxxx> wrote: > > > Back in the days, I introduced that zcopy path for efficiency > > > reasons - getting both better throughput and less CPU load. > > > I looked at both WRITE and READ performance. Using > > > do_tcp_sendpages() is currently limited to processing work > > > which is not registered with local completion generation. > > > Replying to a remote READ request is a typical case. Did > > > you check with READ? > > > > Ah - you're talking about ksmbd there? I haven't tested the patch with > > that. > > Did you test with both kernel ULPs and user level applications? Kernel "ULPs"? As far as cifs goes, I've tested the fs with large dd commands for the moment, but that's all. This post was more to find out how attached people were to ->sendpage() and to see if anyone had any preferences on a couple of things mentioned in the cover note. This isn't aimed at the next merge window. David
