Re: [PATCH for-next v2 1/4] RDMA/rxe: Replace exists by rxe in rxe.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2023 at 09:29:15PM -0600, Bob Pearson wrote:
> 'exists' looks like a boolean. This patch replaces it by the
> normal name used for the rxe device, 'rxe', which should be a
> little less confusing. The second rxe_dbg() message is
> incorrect since rxe is known to be NULL and this will cause a
> seg fault if this message were ever sent. Replace it by pr_debug
> for the moment.
> 
> Fixes: c6aba5ea0055 ("RDMA/rxe: Replace pr_xxx by rxe_dbg_xxx in rxe.c")
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
>  drivers/infiniband/sw/rxe/rxe.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

I don't mind this, but have you thought about instrumenting it
properly with tracepoints?

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux