On 2/21/23 17:26, Jason Gunthorpe wrote: > On Tue, Feb 21, 2023 at 02:54:29PM -0600, Bob Pearson wrote: >> The rxe driver implements UD multicast support by cloning an incoming >> request packet to give one each to the qp's that belong to the multi- >> cast group. If there are N qp's in the group N-1 clones are created >> and for each one a reference is taken to the ib device and a reference >> is taken to the destination qp. This matches the behavior of non >> multicast packets. The packet itself which already has a reference >> to the ib device and the qp is given to the last qp. >> >> Incorrectly, rxe_rcv_mcast_pkt() takes an additional qp reference >> which is not needed and will prevent the qp from being destroyed >> without an error timeout. This patch removes that qp reference. This was all wrong. The incoming packet had qpn = IB_MULTICAST_QPN so it did *not* lookup the qp and take a reference. >> >> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx> >> --- >> drivers/infiniband/sw/rxe/rxe_recv.c | 1 - >> 1 file changed, 1 deletion(-) > > Needs a fixes line.. > > Jason Please withdraw this patch. Bob
