On Tue, 21 Feb 2023 08:39:40 +0200 Leon Romanovsky wrote: > On Mon, Feb 20, 2023 at 04:50:00PM -0800, Jakub Kicinski wrote: > > On Sun, 19 Feb 2023 14:59:57 +0200 Leon Romanovsky wrote: > > > -rule_fail: > > > +fail_rule: > > > mlx5_destroy_flow_group(roce->g); > > > -fail: > > > +fail_group: > > > mlx5_destroy_flow_table(ft); > > > +fail_table: > > > + kvfree(in); > > > return err; > > > > If you're touching all of them please name them after what they do. > > Much easier to review. > > I can change it, but all mlx* drivers and randomly chosen place in ice > use label to show what fail and not what will be done. Such notation > gives an ability to refactor code without changing label names if > failed part of code is not removed. Please refactor, and it'd be great if the convention was changed for all new code in these drivers.
