On 17/02/2023 5:13, Yang Yingliang wrote:
> kvzalloc() returns NULL pointer not PTR_ERR() when it fails,
> so replace the IS_ERR() check with NULL pointer check.
>
> Fixes: d13674b1d14c ("net/mlx5e: TC, map tc action cookie to a hw counter")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c
> index f71766dca660..626cb7470fa5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act_stats.c
> @@ -37,7 +37,7 @@ mlx5e_tc_act_stats_create(void)
> int err;
>
> handle = kvzalloc(sizeof(*handle), GFP_KERNEL);
> - if (IS_ERR(handle))
> + if (!handle)
> return ERR_PTR(-ENOMEM);
>
> err = rhashtable_init(&handle->ht, &act_counters_ht_params);
thanks
Reviewed-by: Roi Dayan <roid@xxxxxxxxxx>
