Re: [PATCH for-next 0/3] Respin: Rework system pinning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2023 at 04:40:32PM -0500, Dennis Dalessandro wrote:
> On 2/17/23 3:41 PM, Jason Gunthorpe wrote:
> > On Thu, Feb 16, 2023 at 11:56:18AM -0500, Dennis Dalessandro wrote:
> >> This is a respin on top of the latest rdma/for-next branch
> >> of the series being discussed on the list here:
> >> https://lore.kernel.org/linux-rdma/Y+EbyU4HkGyzPoFO@xxxxxxxxxx/T/#ma3d153151adf1dbe2b9800000fa9a01f95a80c1f
> >>
> >> We have added fixes lines, and Brendan has discovered a couple code hunks that
> >> do not need to be here in this submission. We have also removed the stats stuff
> >> until the user side code is readily available.
> >>
> >> ---
> >>
> >> Patrick Kelsey (3):
> >>       IB/hfi1: Fix math bugs in hfi1_can_pin_pages()
> >>       IB/hfi1: Fix sdma.h tx->num_descs off-by-one errors
> > 
> > I took these two
> > 
> >>       IB/hfi1: Do SDMA memory-pinning through hfi1's pinning interface
> > 
> > But really? This is almost a thousand lines in just one patch, is that
> > really justified? Can you break it up?
> 
> The bulk of the code is moving functions from user_sdma.c and others into a new
> file, pin_system.c.
> 
> Not sure a bunch of commits "move XZY to pin_system.c" would be very
> helpful.

One doing code motion would be fine

> To be fair, the patch was posted originally almost 6 weeks ago. In that time no
> one has said anything so I don't think there are a bunch of people chomping at
> the bit to review this. Any suggestions to make it easier for your review?

Linus will look at it, it can't be totally crazy

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux