On Thu, Feb 02, 2023 at 04:05:18PM +0200, Leon Romanovsky wrote:
> On Thu, Feb 02, 2023 at 09:56:51AM -0400, Jason Gunthorpe wrote:
> > On Thu, Feb 02, 2023 at 11:03:06AM +0200, Leon Romanovsky wrote:
> > > From: Leon Romanovsky <leonro@xxxxxxxxxx>
> > >
> > > Block MR cache debugfs creation while in switchdev mode and add missing
> > > debugfs cleanup in error path.
> >
> > Why does switchdev have anything to do with this?
> >
>
> Because we always had the following code in cleanup:
> 697 static void mlx5_mkey_cache_debugfs_cleanup(struct mlx5_ib_dev *dev)
> 698 {
> 699 if (!mlx5_debugfs_root || dev->is_rep)
> 700 return;
> 701
>
> MR cache shouldn't be used at all for IB representors, and more
> comprehensive patch will take more work than this simple solution.
That make sense, the commit message should explain it..
Jason
