Re: [PATCH RFC] RDMA/rtrs: Don't call kobject_del for srv_path->kobj

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/2/23 15:59, lizhijian@xxxxxxxxxxx wrote:
6af4609c18b3 seems make senses, so i don't want to revert it entirely if possible.

I have a update for this path like below, i am no longer get problem with this new update.

index c76ba29da1e2..5adba0f754b6 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-srv-sysfs.c
@@ -312,9 +312,8 @@ void rtrs_srv_destroy_path_files(struct rtrs_srv_path *srv_path)
if (srv_path->kobj.state_in_sysfs) {
                  sysfs_remove_group(&srv_path->kobj, &rtrs_srv_path_attr_group);
-               kobject_del(&srv_path->kobj);
                  kobject_put(&srv_path->kobj);
+               rtrs_srv_destroy_once_sysfs_root_folders(srv_path);
          }
- rtrs_srv_destroy_once_sysfs_root_folders(srv_path);
   }

Hmm, I overlooked the kobject hierarchy 😅.

       err = kobject_init_and_add(&srv_path->kobj, &ktype, srv->kobj_paths,
"%s", str);

Pls send a formal patch, and feel free to add my Acked-by.

Thanks,
Guoqing





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux