On Tue, Jan 24, 2023 at 08:27:09AM +0200, Leon Romanovsky wrote: > On Mon, Jan 23, 2023 at 02:32:05PM -0400, Jason Gunthorpe wrote: > > On Sun, Jan 22, 2023 at 02:44:35PM +0200, Leon Romanovsky wrote: > > > > > > And the return of a really big number from ops->get_num_rx_queues is > > > > pretty ugly too, ideally that would be fixed to pass in some function > > > > arguments and obtain the ppriv so it can return the actual maximum > > > > number of queues and we don't waste a bunch of memory.. > > > > > > .get_num_rx_queues() is declared as void, so it can't have any complex > > > logic except returns some global define. > > > > Well, yes, you'd have to add some arguments.. > > Jason, please be realistic. > > We already were in this place, where we wanted to change netdev stack > for our IPoIB deadlock. As you probably remember, that didn't went well. > > I see a little value to change bunch of netdev drivers just to save some > bytes in legacy IPoIB. Well, then don't do it, but the other stuff still has to be fixed. It didn't look like that big a deal to me Jason
