On Tue, Jan 17, 2023 at 01:19:14PM -0600, Dean Luick wrote:
> On 1/16/2023 9:41 AM, Jason Gunthorpe wrote:
> > On Mon, Jan 09, 2023 at 12:31:31PM -0500, Dennis Dalessandro wrote:
> >
> >> + if (fd->use_mn) {
> >> + ret = mmu_interval_notifier_insert(
> >> + &tidbuf->notifier, current->mm,
> >> + tidbuf->vaddr, tidbuf->npages * PAGE_SIZE,
> >> + &tid_cover_ops);
> >
> > This is still not the right way to use these notifiers, you should be
> > removing the calls to mmu_notifier_register()
>
> I am confused by your comment. This is the user expected receive
> code. There are no calls to mmu_notifier_register() here. You
> removed those calls when you added the FIXME. The Send DMA side
> still has calls to mmu_notifier_register(). This series is all
> about user expected receive.
Then something else seems wrong because you shouldn't be removing the
notifiers in the same function you add them
Jason
