> -----Original Message----- > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Friday, December 9, 2022 11:33 AM > To: Saeed Mahameed <saeed@xxxxxxxxxx> > Cc: Ertman, David M <david.m.ertman@xxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; > pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>; Ismail, Mustafa > <mustafa.ismail@xxxxxxxxx>; leonro@xxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; G, GurucharanX <gurucharanx.g@xxxxxxxxx> > Subject: Re: [PATCH net 2/4] ice: Correctly handle aux device when num > channels change > > On Fri, Dec 09, 2022 at 11:28:28AM -0800, Saeed Mahameed wrote: > > > IMO it's wrong to re-initialize a parallel subsystems due to an ethtool, > > ethtool is meant to control the netdev interface, not rdma. > > We've gotten into locking trouble doing stuff like this before. > > If you are holding any locks do not try to unplug/plug an aux device. > > Jason The unplug/plug is done outside the ethtool context. No locks are being held. DaveE
