> On Nov 23, 2022, at 3:03 PM, Anna Schumaker <schumaker.anna@xxxxxxxxx> wrote: > > On Mon, Nov 21, 2022 at 10:15 AM Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote: >> >>> On Nov 17, 2022, at 9:27 AM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: >>> >>> Steven Rostedt says: >>>> The include/trace/events/ directory should only hold files that >>>> are to create events, not headers that hold helper functions. >>>> >>>> Can you please move them out of include/trace/events/ as that >>>> directory is "special" in the creation of events. >>> >>> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> >>> Acked-by: Leon Romanovsky <leonro@xxxxxxxxxx> >>> Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> >>> --- >>> MAINTAINERS | 7 + >>> drivers/infiniband/core/cm_trace.h | 2 >>> drivers/infiniband/core/cma_trace.h | 2 >>> fs/nfs/nfs4trace.h | 6 - >>> fs/nfs/nfstrace.h | 6 - >>> include/trace/events/fs.h | 122 ----------- >>> include/trace/events/nfs.h | 375 ----------------------------------- >>> include/trace/events/rdma.h | 168 ---------------- >>> include/trace/events/rpcgss.h | 2 >>> include/trace/events/rpcrdma.h | 4 >>> include/trace/events/sunrpc.h | 2 >>> include/trace/events/sunrpc_base.h | 18 -- >>> include/trace/misc/fs.h | 122 +++++++++++ >>> include/trace/misc/nfs.h | 375 +++++++++++++++++++++++++++++++++++ >>> include/trace/misc/rdma.h | 168 ++++++++++++++++ >>> include/trace/misc/sunrpc.h | 18 ++ >>> 16 files changed, 702 insertions(+), 695 deletions(-) >>> delete mode 100644 include/trace/events/fs.h >>> delete mode 100644 include/trace/events/nfs.h >>> delete mode 100644 include/trace/events/rdma.h >>> delete mode 100644 include/trace/events/sunrpc_base.h >>> create mode 100644 include/trace/misc/fs.h >>> create mode 100644 include/trace/misc/nfs.h >>> create mode 100644 include/trace/misc/rdma.h >>> create mode 100644 include/trace/misc/sunrpc.h >>> >>> Note: with an Acked-by from both the NFS client and RDMA core >>> maintainers I can take this through the nfsd for-next tree, unless >>> someone has another suggestion. >>> >>> Still missing Acks from the NFS maintainers. >> >> Nudge. > > Acked-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> Thanks! -- Chuck Lever
