On Sat, Oct 15, 2022 at 06:37:03AM +0000, yangx.jy@xxxxxxxxxxx wrote: > The IB SPEC v1.5[1] defined new atomic write operation. This patchset > makes SoftRoCE support new atomic write on RC service. > > On my rdma-core repository[2], I have introduced atomic write API > for libibverbs and Pyverbs. I also have provided a rdma_atomic_write > example and test_qp_ex_rc_atomic_write python test to verify > the patchset. > > The steps to run the rdma_atomic_write example: > server: > $ ./rdma_atomic_write_server -s [server_address] -p [port_number] > client: > $ ./rdma_atomic_write_client -s [server_address] -p [port_number] > > The steps to run test_qp_ex_rc_atomic_write test: > run_tests.py --dev rxe_enp0s3 --gid 1 -v test_qpex.QpExTestCase.test_qp_ex_rc_atomic_write > test_qp_ex_rc_atomic_write (tests.test_qpex.QpExTestCase) ... ok > > ---------------------------------------------------------------------- > Ran 1 test in 0.008s > > OK > > [1]: https://www.infinibandta.org/wp-content/uploads/2021/08/IBTA-Overview-of-IBTA-Volume-1-Release-1.5-and-MPE-2021-08-17-Secure.pptx > [2]: https://github.com/yangx-jy/rdma-core/tree/new_api_with_point > > v5->v6: > 1) Rebase on current for-next > 2) Split the implementation of atomic write into 7 patches > 3) Replace all "RDMA Atomic Write" with "atomic write" > 4) Save 8-byte value in struct rxe_dma_info instead > 5) Remove the print in atomic_write_reply() I think this looked OK, please fix the enum thing and also resolve all the remarks on the github and rebase/repost/retest both series. Thanks, Jason