Re: [PATCH] RDMA/hns: fix memory leak in hns_roce_alloc_mr()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022/11/19 15:08:34, Zhengchao Shao wrote:
> When hns_roce_mr_enable() failed in hns_roce_alloc_mr(), mr_key is not
> released. Compiled test only.
> 
> Fixes: 9b2cf76c9f05 ("RDMA/hns: Optimize PBL buffer allocation process")
> Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx>
> ---
>  drivers/infiniband/hw/hns/hns_roce_mr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
> index 845ac7d3831f..37a5cf62f88b 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_mr.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
> @@ -392,10 +392,10 @@ struct ib_mr *hns_roce_alloc_mr(struct ib_pd *pd, enum ib_mr_type mr_type,
>  
>  	return &mr->ibmr;
>  
> -err_key:
> -	free_mr_key(hr_dev, mr);
>  err_pbl:
>  	free_mr_pbl(hr_dev, mr);
> +err_key:
> +	free_mr_key(hr_dev, mr);
>  err_free:
>  	kfree(mr);
>  	return ERR_PTR(ret);
> 

Thank you. For the patch:
Acked-by Haoyue Xu <xuhaoyue1@xxxxxxxxxxxxx>

Regards,
Haoyue



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux