Yes. I saw that. I missed the 0-day connection. Yes I'll add the 'static' declaration. Bob -----Original Message----- From: Jason Gunthorpe <jgg@xxxxxxxxxx> Sent: Friday, October 28, 2022 2:16 PM To: Bob Pearson <rpearsonhpe@xxxxxxxxx> Cc: zyjzyj2000@xxxxxxxxx; leon@xxxxxxxxxx; Hack, Jenny (Ft. Collins) <jhack@xxxxxxx>; Ziemba, Ian <ian.ziemba@xxxxxxx>; matsuda-daisuke@xxxxxxxxxxx; lizhijian@xxxxxxxxxxx; haris.phnx@xxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx Subject: Re: [PATCH v2 00/18] Implement work queues for rdma_rxe On Fri, Oct 28, 2022 at 01:58:08PM -0500, Bob Pearson wrote: > On 10/28/22 13:17, Jason Gunthorpe wrote: > > On Fri, Oct 28, 2022 at 01:16:11PM -0500, Bob Pearson wrote: > >> On 10/28/22 12:04, Jason Gunthorpe wrote: > >>>> Bob Pearson (18): > >>>> RDMA/rxe: Remove redundant header files > >>>> RDMA/rxe: Remove init of task locks from rxe_qp.c > >>>> RDMA/rxe: Removed unused name from rxe_task struct > >>>> RDMA/rxe: Split rxe_run_task() into two subroutines > >>>> RDMA/rxe: Make rxe_do_task static > >>> > >>> I took these patches into for-next, the rest will need reposting > >>> to address the 0-day and decide if we should strip out the work > >>> queue entirely > >>> > >>> Jason > >> > >> I'm guessing you meant tasklet?? > > > > yes > > > > Jason > > What do you mean by 0-day?? Sounds like a cpu bug we used to talk > about. But not sure what it has to do with work queue patches. https://lore.kernel.org/linux-rdma/202210220559.f7taTL8S-lkp@xxxxxxxxx/ Jason
