On Thu, Oct 27, 2022 at 03:01:16PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxx>
>
> Destroy XArray while releasing qedr resources.
>
> Fixes: b6014f9e5f39 ("qedr: Convert qpidr to XArray")
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> ---
> I'm sending it to -rc just because of dependency on
> https://lore.kernel.org/linux-rdma/166687129991.306571.17052575958640789335.b4-ty@xxxxxxxxxx/T/#m0e945baa7f2c87ede9f1711c992889602ede7875
> qps is empty and nothing is really leaked here.
if qps is known to be empty then this should be WARN_ON(!xa_empty()) -
destroying an xarray that holds allocated memory is never correct - it
will leak the elements
Also, this isn't "for-rc", so it should go to -next. With a dependency
like this the patch waits until linus merges the rc branch and then
-next merges linus's rcX tag to resolve the conflict.
Jason
