I will send V2 to fix it. On 2022/10/25 20:47:33, kernel test robot wrote: > Hi Haoyue, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on rdma/for-next] > [also build test WARNING on linus/master v6.1-rc2 next-20221025] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Haoyue-Xu/Fix-sge_num-bug-and-add-cqe-inline-refactor-rq-inline/20221025-185626 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next > patch link: https://lore.kernel.org/r/20221025105244.204570-3-xuhaoyue1%40hisilicon.com > patch subject: [PATCH 2/5] RDMA/hns: Fix the problem of sge nums > config: ia64-allyesconfig (attached as .config) > compiler: ia64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/b277a5cdd36f6cfac1e387afd3b670052041e9df > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Haoyue-Xu/Fix-sge_num-bug-and-add-cqe-inline-refactor-rq-inline/20221025-185626 > git checkout b277a5cdd36f6cfac1e387afd3b670052041e9df > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/infiniband/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > >>> drivers/infiniband/hw/hns/hns_roce_qp.c:510: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Calculated sge num according to attr's max_send_sge > drivers/infiniband/hw/hns/hns_roce_qp.c:525: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Calculated sge num according to attr's max_inline_data > > > vim +510 drivers/infiniband/hw/hns/hns_roce_qp.c > > 508 > 509 /** > > 510 * Calculated sge num according to attr's max_send_sge > 511 */ > 512 static u32 get_sge_num_from_max_send_sge(bool is_ud_or_gsi, > 513 u32 max_send_sge) > 514 { > 515 unsigned int std_sge_num; > 516 unsigned int min_sge; > 517 > 518 std_sge_num = is_ud_or_gsi ? 0 : HNS_ROCE_SGE_IN_WQE; > 519 min_sge = is_ud_or_gsi ? 1 : 0; > 520 return max_send_sge > std_sge_num ? (max_send_sge - std_sge_num) : > 521 min_sge; > 522 } > 523 >
