On Tue, Oct 25, 2022 at 09:35:01AM +0000, Daisuke Matsuda (Fujitsu) wrote: > On Sat, Oct 22, 2022 5:01 AM Bob Pearson: > > > > Add modparams to control the task types for req, comp, and resp > > tasks. > > > > It is expected that the work queue version will take the place of > > the tasklet version once this patch series is accepted and moved > > upstream. However, for now it is convenient to keep the option of > > easily switching between the versions to help benchmarking and > > debugging. > > > > Signed-off-by: Ian Ziemba <ian.ziemba@xxxxxxx> > > Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx> > > --- > > drivers/infiniband/sw/rxe/rxe_qp.c | 6 +++--- > > drivers/infiniband/sw/rxe/rxe_task.c | 8 ++++++++ > > drivers/infiniband/sw/rxe/rxe_task.h | 4 ++++ > > 3 files changed, 15 insertions(+), 3 deletions(-) > > <...> > > > diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c > > index 9b8c9d28ee46..4568c4a05e85 100644 > > --- a/drivers/infiniband/sw/rxe/rxe_task.c > > +++ b/drivers/infiniband/sw/rxe/rxe_task.c > > @@ -6,6 +6,14 @@ > > > > #include "rxe.h" > > > > +int rxe_req_task_type = RXE_TASK_TYPE_TASKLET; > > +int rxe_comp_task_type = RXE_TASK_TYPE_TASKLET; > > +int rxe_resp_task_type = RXE_TASK_TYPE_TASKLET; > > As the tasklet version is to be eliminated in near future, why > don't we make the workqueue version default now? Why don't we just get rid of the tasklet version right away? Jason
