On Tue, Oct 18, 2022 1:34 PM Bob Pearson wrote:
> The subroutine rxe_do_task() is only called in rxe_task.c. This patch
> makes it static and renames it do_task().
>
> Signed-off-by: Ian Ziemba <ian.ziemba@xxxxxxx>
> Signed-off-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
> ---
While the description above says "renames it do_task()", this patch
actually does not rename. Because of this, I failed to apply the 5th patch.
BTW, thank you very much for posting the patches.
Daisuke
> drivers/infiniband/sw/rxe/rxe_task.c | 2 +-
> drivers/infiniband/sw/rxe/rxe_task.h | 8 --------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c
> index 446ee2c3d381..097ddb16c230 100644
> --- a/drivers/infiniband/sw/rxe/rxe_task.c
> +++ b/drivers/infiniband/sw/rxe/rxe_task.c
> @@ -28,7 +28,7 @@ int __rxe_do_task(struct rxe_task *task)
> * a second caller finds the task already running
> * but looks just after the last call to func
> */
> -void rxe_do_task(struct tasklet_struct *t)
> +static void rxe_do_task(struct tasklet_struct *t)
> {
> int cont;
> int ret;
> diff --git a/drivers/infiniband/sw/rxe/rxe_task.h b/drivers/infiniband/sw/rxe/rxe_task.h
> index 590b1c1d7e7c..99e0173e5c46 100644
> --- a/drivers/infiniband/sw/rxe/rxe_task.h
> +++ b/drivers/infiniband/sw/rxe/rxe_task.h
> @@ -44,14 +44,6 @@ void rxe_cleanup_task(struct rxe_task *task);
> */
> int __rxe_do_task(struct rxe_task *task);
>
> -/*
> - * common function called by any of the main tasklets
> - * If there is any chance that there is additional
> - * work to do someone must reschedule the task before
> - * leaving
> - */
> -void rxe_do_task(struct tasklet_struct *t);
> -
> void rxe_run_task(struct rxe_task *task);
>
> void rxe_sched_task(struct rxe_task *task);
> --
> 2.34.1
