On 9/26/22 20:38, matsuda-daisuke@xxxxxxxxxxx wrote: > On Tue, Sep 27, 2022 8:14 AM, Jason Gunthorpe wrote: >> On Fri, Sep 16, 2022 at 10:10:51PM -0500, Bob Pearson wrote: >>> This patch series implements the xrc transport for the rdma_rxe driver. >>> It is based on the current for-next branch of rdma-linux. >>> The first two patches in the series do some cleanup which is helpful >>> for this effort. The remaining patches implement the xrc functionality. >>> There is a matching patch set for the user space rxe provider driver. >>> The communications between these is accomplished without making an >>> ABI change by taking advantage of the space freed up by a recent >>> patch called "Remove redundant num_sge fields" which is a reprequisite >>> for this patch series. >>> >>> The two patch sets have been tested with the pyverbs regression test >>> suite with and without each set installed. This series enables 5 of >>> the 6 xrc test cases in pyverbs. The ODP case does is currently skipped >>> but should work once the ODP patch series is accepted. >> >> The ODP patch isn't even on patchworks any more, so it needs >> resending. I can't remember why it needed respin now. > > The ODP patch series is the one I posted for rxe this month: > [RFC PATCH 0/7] RDMA/rxe: On-Demand Paging on SoftRoCE > https://lore.kernel.org/lkml/cover.1662461897.git.matsuda-daisuke@xxxxxxxxxxx/ > https://patchwork.kernel.org/project/linux-rdma/list/?series=674699&state=%2A&archive=both > > We had an argument about the way to use workqueues instead of tasklets. > Some prefer to get rid of tasklets, but others prefer finding a way to switch > between the bottom halves for performance reasons. I am currently taking > some data to continue the discussion while waiting for Bob to post their(HPE's) > implementation that enables the switching. I think I can resend the ODP patches > without an RFC tag once we reach an agreement on this point. I tried to get Ian Ziemba, who wrote the patch series, to send it in but he is very busy and finally after a long while he asked me to do that. I have to rebase it from an older kernel to head of tree. I hope to have that done in a day or two. Bob > > Thanks, > Daisuke Matsuda > >> >> I'm inclined to apply this without really looking closely at the rxe >> code. If someone has other ideas please chime in. It looks like it >> needs rebasing, yes? >> >> Jason