On 9/26/22 10:29 PM, Shang XiaoJing wrote:
> Use skb_put_data() instead of skb_put() and memcpy(), which is shorter
> and clear. Drop the tmp variable that is not needed any more.
>
> Signed-off-by: Shang XiaoJing <shangxiaojing@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/ipoib_rx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_rx.c b/drivers/infiniband/hw/hfi1/ipoib_rx.c
> index 3afa7545242c..629691a572ef 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_rx.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_rx.c
> @@ -11,13 +11,10 @@
>
> static void copy_ipoib_buf(struct sk_buff *skb, void *data, int size)
> {
> - void *dst_data;
> -
> skb_checksum_none_assert(skb);
> skb->protocol = *((__be16 *)data);
>
> - dst_data = skb_put(skb, size);
> - memcpy(dst_data, data, size);
> + skb_put_data(skb, data, size);
> skb->mac_header = HFI1_IPOIB_PSEUDO_LEN;
> skb_pull(skb, HFI1_IPOIB_ENCAP_LEN);
> }
Seems OK to me. Although I don't know that it's any more "clear". More
appropriate commit message would say it removes the open coded way of doing
things. Regardless...
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx>
