On Tue, Sep 20, 2022 at 06:22:20PM -0700, longli@xxxxxxxxxxxxxxxxx wrote: > From: Long Li <longli@xxxxxxxxxxxxx> > > This patchset implements a RDMA driver for Microsoft Azure Network > Adapter (MANA). In MANA, the RDMA device is modeled as an auxiliary device > to the Ethernet device. > > The first 11 patches modify the MANA Ethernet driver to support RDMA driver. > The last patch implementes the RDMA driver. > > The user-mode of the driver is being reviewed at: > https://github.com/linux-rdma/rdma-core/pull/1177 > > > Ajay Sharma (3): > net: mana: Set the DMA device max segment size > net: mana: Define and process GDMA response code > GDMA_STATUS_MORE_ENTRIES > net: mana: Define data structures for protection domain and memory > registration > > Long Li (9): > net: mana: Add support for auxiliary device > net: mana: Record the physical address for doorbell page region > net: mana: Handle vport sharing between devices > net: mana: Add functions for allocating doorbell page from GDMA > net: mana: Export Work Queue functions for use by RDMA driver > net: mana: Record port number in netdev > net: mana: Move header files to a common location > net: mana: Define max values for SGL entries > RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter Still some basic checkpatchy stuff: /tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:412: WARNING: quoted string split across lines #412: FILE: drivers/infiniband/hw/mana/main.c:70: + "vport handle %llx pdid %x doorbell_id %x " + "tx_shortform_allowed %d tx_vp_offset %u\n", /tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:540: WARNING: quoted string split across lines #540: FILE: drivers/infiniband/hw/mana/main.c:198: + "size_dma_region %lu num_pages_total %lu, " + "page_sz 0x%llx offset_in_page %u\n", And it thinks you should write more for the kconfig symbol, eg why would someone want to turn it on (hint, to use dpkd on some Azure instances) /tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:100: WARNING: please write a help paragraph that fully describes the config symbol #100: FILE: drivers/infiniband/hw/mana/Kconfig:2: +config MANA_INFINIBAND + tristate "Microsoft Azure Network Adapter support" + depends on NETDEVICES && ETHERNET && PCI && MICROSOFT_MANA + help + This driver provides low-level RDMA support for + Microsoft Azure Network Adapter (MANA). I'll put it in linux-next and you can fix the rest of the stuff bots will usually find. Jason