Looks good. As clt->pcpu_path is of type "struct rtrs_clt_path __rcu **ppcpu_path", using without typecasting with cmpxchg() would fetch sparse warning. I still believe we can use rcu_replace_pointer() instead of cmpxchg(), anyway we are going to allow RCU grace period using synchronize_rcu(). Best Regards, Santosh On Thu, Sep 8, 2022 at 12:06 PM Guoqing Jiang <guoqing.jiang@xxxxxxxxx> wrote: > > > > On 9/8/22 5:55 PM, Haris Iqbal wrote: > > On Thu, Sep 8, 2022 at 11:46 AM Guoqing Jiang<guoqing.jiang@xxxxxxxxx> wrote: > >> Let's call try_cmpxchg directly for the same purpose. > >> > >> Acked-by: Md Haris Iqbal<haris.iqbal@xxxxxxxxx> > >> Signed-off-by: Guoqing Jiang<guoqing.jiang@xxxxxxxxx> > >> Reported-by: kernel test robot<lkp@xxxxxxxxx> > > I am not sure whats the correct way of using this. But technically, > > this change was NOT done due to a report from the "kernel test robot". > > It only pointed out the problem in the original patch. To the branch > > maintainers, if its okay to keep this in this scenario, then ignore > > this comment. > > Me either, just want to give credit to lkp for previous report, but not sure > if there is a better tag. > > Thanks, > Guoqing
