> -----Original Message----- > From: Tom Talpey <tom@xxxxxxxxxx> > Sent: Wednesday, 31 August 2022 18:31 > To: Jason Gunthorpe <jgg@xxxxxxxxxx>; Leon Romanovsky <leonro@xxxxxxxxxx>; > linux-rdma@xxxxxxxxxxxxxxx; Bernard Metzler <BMT@xxxxxxxxxxxxxx> > Subject: [EXTERNAL] [PATCH] RDMA/siw: Add missing Kconfig selections > > The SoftiWARP Kconfig is missing "select" for CRYPTO and CRYPTO_CRC32C. > > In addition, it improperly "depends on" LIBCRC32C, this should be a > "select", similar to net/sctp and others. As a dependency, SIW fails > to appear in generic configurations. > Many thanks for taking care, Tom. Indeed, siw currently only 'accidentally' benefits from having the two CRYPTO dependencies selected by other code. And 'depends' was not correct either, since it limits siw visibility in kernel configurations. Thank you! Acked-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx> > Signed-off-by: Tom Talpey <tom@xxxxxxxxxx> > --- > drivers/infiniband/sw/siw/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/siw/Kconfig > b/drivers/infiniband/sw/siw/Kconfig > index 1b5105cbabae..81b70a3eeb87 100644 > --- a/drivers/infiniband/sw/siw/Kconfig > +++ b/drivers/infiniband/sw/siw/Kconfig > @@ -1,7 +1,10 @@ > config RDMA_SIW > tristate "Software RDMA over TCP/IP (iWARP) driver" > - depends on INET && INFINIBAND && LIBCRC32C > + depends on INET && INFINIBAND > depends on INFINIBAND_VIRT_DMA > + select LIBCRC32C > + select CRYPTO > + select CRYPTO_CRC32C > help > This driver implements the iWARP RDMA transport over > the Linux TCP/IP network stack. It enables a system with a
