On 8/25/22 06:02, Daisuke Matsuda wrote:
> When responder cannot copy data from a user MR, error messages overflow.
> This is because an incoming RDMA Read request can results in multiple Read
> responses. If the target MR is somehow unavailable, then the error message
> is generated for every Read response.
>
> For the same reason, the error message for packet transmission should also
> be ratelimited.
>
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@xxxxxxxxxxx>
> ---
> drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
> index b36ec5c4d5e0..f9e9679b5e32 100644
> --- a/drivers/infiniband/sw/rxe/rxe_resp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_resp.c
> @@ -812,7 +812,7 @@ static enum resp_states read_reply(struct rxe_qp *qp,
> err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
> payload, RXE_FROM_MR_OBJ);
> if (err)
> - pr_err("Failed copying memory\n");
> + pr_err_ratelimited("Failed copying memory\n");
> if (mr)
> rxe_put(mr);
>
> @@ -824,7 +824,7 @@ static enum resp_states read_reply(struct rxe_qp *qp,
>
> err = rxe_xmit_packet(qp, &ack_pkt, skb);
> if (err) {
> - pr_err("Failed sending RDMA reply.\n");
> + pr_err_ratelimited("Failed sending RDMA reply.\n");
> return RESPST_ERR_RNR;
> }
>
Reviewed-by: Bob Pearson <rpearsonhpe@xxxxxxxxx>
