On Fri, Aug 05, 2022 at 12:48:32PM -0500, Bob Pearson wrote: > On 8/5/22 02:08, lizhijian@xxxxxxxxxxx wrote: > > Bob > > > > It does fix the panic. > > > > TBH i'm not a big fan with you patches style, you didn't make the smallest patch. > > You made a lots of extra cleanups and coding style fixes which is good to me in logical > > but it make patches massive. that would take people more attention to have a review. > > > > I'd like a smallest fix + extra cleanup if needed, the decision is up to the maintainers :) > > > > > > > Li, > > OK. I'll split it up. I'm ambivalent on goto's. Some days I like them and some I don't. No logical reason. > In this particular case I was concerned with making absolutely sure that the cleanups balanced out. > So I touched all that code in passing. Now that it works. I can reduce the change. kernel style is goto unwind on error, you should use it freely and never duplicate error unwind in branches.. Jason
