Re: [PATCH for-next v2] RDMA/rxe: Cleanup rxe_init_packet()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 27, 2022 at 11:36:52AM -0500, Bob Pearson wrote:
>  	unsigned int hdr_len;
>  	struct sk_buff *skb = NULL;
> -	struct net_device *ndev;
> -	const struct ib_gid_attr *attr;
> +	struct net_device *ndev = rxe->ndev;
>  	const int port_num = 1;
> -
> -	attr = rdma_get_gid_attr(&rxe->ib_dev, port_num, av->grh.sgid_index);
> -	if (IS_ERR(attr))
> -		return NULL;

An ib_device can have many netdevs associated with the gid indexes, eg
from VLANs or LAG. The core code creates these things

I think it is nonsense for rxe to work like this, and perhaps it
doesn't work at all, but until rxe blocks creation of these other gid
indexes I'm not sure it makes sense to delete this code..

Jason



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux