On 7/27/22 05:31, Leon Romanovsky wrote:
On Wed, Jul 27, 2022 at 02:26:43PM +0200, Christoph Lameter wrote:
On Wed, 27 Jul 2022, Leon Romanovsky wrote:
Please no BUG_ON() in new code.
Do we now prefer NULL pointer dereferences causing bugs?
There are two possible scenarios.
1. "NULL can be in this flow." - In such case, the code should deal with
such flow and do not crash whole machine.
2. "NULL can't be in this flow." - Put WARN_ON() which serves as a
documentation/debug help to catch situations that are not possible.
Hi Leon and Christoph,
Thanks for having taken a look. Since the wwn.priv pointers cannot be
NULL, I will remove the BUG_ON() statements that check these pointers.
Bart.
