Re: [PATCH v5 0/4] RDMA/rxe: Fix no completion event issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 20, 2022 at 06:21:29AM +0000, lizhijian@xxxxxxxxxxx wrote:
> Hi Leon
> 
> 
> On 20/07/2022 13:38, Leon Romanovsky wrote:
> > On Mon, Jul 04, 2022 at 06:00:54AM +0000, lizhijian@xxxxxxxxxxx wrote:
> >
> > Please fix your gitconfig to have same From/author fields as in Signed-off-by.
> 
> I'm sorry about that, tay I know which patch has something wrong? I have not updated these fields recently.
> Do you mean "[PATCH v5 3/4] RDMA/rxe: Split qp state for requester and completer" which is from Bob. So
> I keep his author and SOB.

No, I'm talking about something else. Almost all your patches are sent
with wrong "From:" field.

Let's take your first patch as an example:
https://lore.kernel.org/linux-rdma/20220704060806.1622849-2-lizhijian@xxxxxxxxxxx/
From: "lizhijian@xxxxxxxxxxx" <lizhijian@xxxxxxxxxxx>
...
Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>

and if i try to apply it, the checkpatch will throw the following error:
➜  kernel git:(rdma-next) ✗ git am --continue
Applying: RDMA/rxe: Update wqe_index for each wqe error completion
➜  kernel git:(rdma-next) git checkpatch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
qp->req.wqe_index==queue.index in next round, req_next_wqe() will treat queue

WARNING: From:/Signed-off-by: email name mismatch: 'From: "lizhijian@xxxxxxxxxxx" <lizhijian@xxxxxxxxxxx>' != 'Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>'

0001-RDMA-rxe-Update-wqe_index-for-each-wqe-error-complet.patch total: 0 errors, 2 warnings, 8 lines checked


> 
> Thanks
> Zhijian
> 
> 
> >
> > Thanks



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux